Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link executables dynamically to speed up linking #4423

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

develop7
Copy link
Contributor

@develop7 develop7 commented Oct 12, 2024

Dramatically decreases linking times and shaves 6 of 14G off HLS' dist-newstyle directory on my machine by producing way smaller executables.

While cabal building HLS after switching a branch I've noticed linking test executables takes minutes, plural, each. Then I've checked the size of a freshly-built test binary and it was 150-something megabytes, no wonder linker took a while. With executable-dynamic enabled, linking is lightning fast and binaries are a megabyte at most, which should probably improve the developer experience and decrease the feedback loop time.

UPD: #2659 seems related, not sure how up-to-date though

@develop7 develop7 marked this pull request as ready for review October 12, 2024 11:35
@develop7 develop7 requested a review from michaelpj as a code owner October 12, 2024 11:35
@fendor
Copy link
Collaborator

fendor commented Oct 12, 2024

I am not sure what ramification this change might have. @wz1000 or @michaelpj, what do you think?
We could also try to enabling it in CI only.

@fendor fendor requested a review from wz1000 October 30, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants